doc(Icons): a comprehensive list of Icons #5564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request updates several BootstrapBlazor icon packages to their latest versions and introduces comprehensive icon lists for AntDesign, IconPark, OctIcons, and ElementIcons within the sample application. The changes involve updating package references in the project file and adding new Razor components to display the icons. Additionally, CSS was updated to adjust the width of IconPark icons. Updated Class Diagram for IconParks ComponentclassDiagram
class IconParks {
+string Assets
+IStringLocalizer Localizer
+Task OnInitializedAsync()
}
IconParks -- IconParkList : Uses
note for IconParks "Displays IconPark icons"
class IconParkList {
+ByteDanceIcon[] Icons
}
Updated Class Diagram for OctIcons ComponentclassDiagram
class OctIcons {
+string Assets
+IStringLocalizer Localizer
+Task OnInitializedAsync()
}
OctIcons -- OcticonIconList : Uses
note for OctIcons "Displays OctIcons"
class OcticonIconList {
+OctIcon[] Icons
}
Updated Class Diagram for ElementIcons ComponentclassDiagram
class ElementIcons {
+string Assets
+IStringLocalizer Localizer
+Task OnInitializedAsync()
}
ElementIcons -- ElementIconList : Uses
note for ElementIcons "Displays ElementIcons"
class ElementIconList {
+ElementIcon[] Icons
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a loop or a more concise way to render the lists of icons instead of manually adding each one.
- The added icon list files are very large; consider if they can be split into smaller files or lazy-loaded.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5564 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29605 29605
Branches 4172 4172
=========================================
Hits 29605 29605 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5563
Summary By Copilot
This pull request includes updates to package versions and adds a comprehensive list of AntDesign icons to the
AntDesignIconListFilled.razorfile.Package Updates:
BootstrapBlazor.AntDesignIconpackage version from9.0.2to9.0.3inBootstrapBlazor.Server.csproj.BootstrapBlazor.ElementIconpackage version from9.0.2to9.0.3inBootstrapBlazor.Server.csproj.BootstrapBlazor.IconParkpackage version from9.0.2to9.0.3inBootstrapBlazor.Server.csproj.BootstrapBlazor.OctIconpackage version from9.0.3to9.0.4inBootstrapBlazor.Server.csproj.Icon Additions:
AntDesignIconelements with theFilledcategory toAntDesignIconListFilled.razor.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Adds comprehensive lists of icons to the sample pages for AntDesign, IconPark, OctIcon, and ElementIcon. Updates package versions for icon libraries.
Enhancements: